[DW] split_client updated logs#459
Merged
Merged
Conversation
chillaq
requested changes
May 10, 2023
| true | ||
| elsif split_name.is_a?(String) && split_name.empty? | ||
| @config.logger.warn("#{calling_method}: you passed an empty split_name, split_name must be a non-empty String or a Symbol") | ||
| @config.logger.warn("#{calling_method}: you passed an empty feature_flag_name, flag name must be a non-empty String or a Symbol") |
Contributor
There was a problem hiding this comment.
update flag_name to feature_flag_name
Contributor
Author
There was a problem hiding this comment.
hey @chillaq i am reviewing the spec and my changes are fine. 🤔
| false | ||
| else | ||
| @config.logger.warn("#{calling_method}: you passed an invalid split_name, split_name must be a non-empty String or a Symbol") | ||
| @config.logger.warn("#{calling_method}: you passed an invalid feature_flag_name, flag name must be a non-empty String or a Symbol") |
Contributor
There was a problem hiding this comment.
update flag_name to feature_flag_name
| expect(log.string).to include 'get_treatments: you passed an invalid split_name, ' \ | ||
| 'split_name must be a non-empty String or a Symbol' | ||
| expect(log.string).to include 'get_treatments: you passed an invalid feature_flag_name, ' \ | ||
| 'flag name must be a non-empty String or a Symbol' |
Contributor
There was a problem hiding this comment.
update flag_name to feature_flag_name
| expect(log.string).to include 'get_treatments: you passed an empty split_name, ' \ | ||
| 'split_name must be a non-empty String or a Symbol' | ||
| expect(log.string).to include 'get_treatments: you passed an empty feature_flag_name, ' \ | ||
| 'flag name must be a non-empty String or a Symbol' |
Contributor
There was a problem hiding this comment.
update flag_name to feature_flag_name
chillaq
approved these changes
May 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby SDK
What did you accomplish?